[GR-51805] Verify init memory semantics #9687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
…CommitAllocationNodes
…th a PublishWritesNode
Benchmark has shown that this does not result in a measurable improvement in performance or memory usage. In the future we could try to a chieve a similar result by postponing lowering of CommitAllocationNodes.
graalvmbot
force-pushed
the
crefice/verify-killed-init
branch
from
1177b2d to
162e9bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an explicit verification phase,
InitMemoryVerificationPhase, that checks that all writes to init memory locations are "published" by aPublishWritesNode(also introduced by this PR, to replaceFixedValueAnchorNode). This means all subsequent reads are connected to thePublishWritesNodeinstead of the original allocation node.The javadoc for
PublishWritesNodeincludes an explanation of init memory semantics.